DX: SCSS formatter
The SCSS code has recently changed its formatting. We would like to build on reproducible formatting rules, in so consistency can be guaranteed.
The project already uses Prettier in package.json, and we could seek to integrate an SCSS Prettier plugin into the build.
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Jon Richter added flow::scoping label
added flow::scoping label
- Jon Richter changed the description
changed the description
- Jon Richter added flow::ready label and removed flow::scoping label
added flow::ready label and removed flow::scoping label
- Flupsi mentioned in issue #19 (closed)
mentioned in issue #19 (closed)
Apparently, prettier uses stylelint, which can be configured:
https://github.com/stylelint/stylelint/blob/main/docs/user-guide/rules.md
As for now, let's use the default, and note all style conventions in the README.
- Jon Richter assigned to @yala
assigned to @yala
- Jon Richter mentioned in issue #33 (closed)
mentioned in issue #33 (closed)
- Jon Richter unassigned @yala
unassigned @yala
- Jon Richter added flow::scoping label and removed flow::ready label
added flow::scoping label and removed flow::ready label
- Flupsi changed title from SCSS formatter to DX: SCSS formatter
changed title from SCSS formatter to DX: SCSS formatter
- Flupsi mentioned in issue #50 (closed)
mentioned in issue #50 (closed)
We are no longer using (S)CSS files.
Motivation: Reduce the number of toolchains and different languages. Typescript has significantly better tooling support than (S)CSS and allows us to cohese and colocate code.
#104 (closed) No more (s)css files
Combined issue: #105 (closed) Cohesive style pipeline
Also note that #33 (closed) Biome is superseding the current prettier/stylelint/eslint/prettier-eslint config
- Author Owner
Does this mean this issue can be closed, with regards to its initial criteria?
Or should it rather be rescoped to the new environment? I guess when #104 (closed) is implemented, this is superseded by TypeScript itself?
Edited by Jon Richter - Jon Richter mentioned in merge request !84 (merged)
mentioned in merge request !84 (merged)
- Jon Richter added flow::review label and removed flow::scoping label
added flow::review label and removed flow::scoping label
- Jon Richter assigned to @upsiflu
assigned to @upsiflu
- Flupsi closed with merge request !84 (merged)
closed with merge request !84 (merged)