Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • D django-vocabulator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 11
    • Issues 11
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Value Flows
  • VF Code Experiments
  • django-vocabulator
  • Issues
  • #3
Closed
Open
Created Mar 24, 2017 by Bob Haugen@bhaugenOwner

Request for ongoing code review

Especially re https://github.com/valueflows/vocabulator/blob/master/vocab/models.py

As @fosterlynn mentioned, I am working with a relational data model. I can do a little inheritance, but it's also a little ugly.

I am doing this to get something deployed that is usable, and also because I want to support relational models as well as RDF-based models as well as plain old json and CSVs.

You can see the current output formats here: https://github.com/valueflows/vocabulator/blob/master/vocab/views.py#L20

More can be added, or if any of those are not needed, they can be removed.

This will all change over time. The current models are not fully implemented yet, but see next issue...

Assignee
Assign to
Time tracking