Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • V vf-graphql
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 22
    • Issues 22
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Value Flows
  • VF Schemas
  • vf-graphql
  • Issues
  • #91

Closed
Open
Created Dec 13, 2021 by pospi@pospiOwner5 of 5 tasks completed5/5 tasks

Ensure all nullable / non-nullable field definitions are as intended

Those yucky exclamation marks haven't been done consistently, and this has thus far been overlooked since loosely typed languages have historically been the only client apps. Bonfire's Elixr UIs are changing that, and such inconsistencies need to be fixed.

  • All delete* mutations should return non-nullable values.
  • All mutation input arguments should be non-nullable for mutations which accept a single structured payload as an argument.
  • All mutations should return non-nullable objects
  • Fix AgentRelationship.inScopeOf not being manageable via its create / update mutations.
  • For all update* mutations which accept a single structured data payload, all parameters except the id should be nullable. RecipeProcessUpdateParams.processConformsTo is the only known issue with regard to this, but a QA pass would be advisable.

Since it came up in QA, also note that Measure.hasUnit is intended to be nullable, and that Measure does not have an ID field.

Edited Dec 31, 2021 by srfsh
Assignee
Assign to
Time tracking