Commit 6990ae44 authored by Gualter's avatar Gualter
Browse files

Remove subcategories matching on reviewers ability (#213)

parent f6bde1b3
Loading
Loading
Loading
Loading
+1 −7
Changes for app/models/ability.rb: 1 added line, 7 removed lines.
Original line number Diff line number Diff line
@@ -93,19 +93,13 @@ class Ability
      # Submitters can read events they are involved in
      # Can read events of the subcategory that they have submitted an individual paper in
      can :read, Event do |event|
        @user.person.in?(event.people) or
            if @user.person.submitted_individual_paper_in?(@conference)
              event.subcategory.in?(@user.person.subcategories_submitted_in(@conference))
            else
              false
            end
        @user.person.in?(event.people)
      end

      can :reserve_for_peer_review, Event do |event|
        @user.person.submitted_individual_paper_in?(@conference)                    and # has submitted individual paper in the conference
        event.event_type == 'Individual Paper'                                      and # Is Individual Paper
        event.conference == @conference                                             and # Is in the correct conference
        event.subcategory.in?(@user.person.subcategories_submitted_in(@conference)) and # Is of the right subcategory
        not event.review_reservations.where(person: @user.person).any?              and # Has not already been reserved by user
        not event.event_ratings.where(person: @user.person).any?                    and # Has not already reviewed
        (event.ratings_by_submitters + event.peer_review_reservations_count) < 2    and # has neither 2 reviews by peers, nor 2 reservations, nor 1 review 1 reservation