time:inXSDDateTimeStamp in examples
Moving a chat conversation between @jvanbockryck and me to a new issue. To summarize, the concern is that we are using time:inXSDDateTimeStamp for the point in time property in the examples, but it doesn't appear anywhere else (UML, json-schemas, graphql), nor does it appear in our vf rdf representation, since it is not vf. To use :hasPointInTime in the examples, it would have to be defined in rdf somewhere.
yeff 12:15 PM Hi Lynn, I was going through the YAML examples in the examples section and I found the "time" attribute in EconomicEvent. Is this still correct? There are many time attributes in EconomicEvent, but "time" isn't as such in the schema, right?
fosterlynn 3:39 PM Hi Jef, Can you tell me which example? EconomicEvents do need some sort of date-time element, it can be a point in time, a start and end, a "before" or "after", although less often. All of those come from the "time" vocabulary in the end, although we've defined hasBeginning and hasEnd also as vf properties. If you are seeing "time" by itself, that is wrong.
Fri, Oct 04, 2019 yeff 7:52 AM Hi Lynn, two examples are in here: https://github.com/valueflows/valueflows/blob/master/examples/checkout-book.yaml GitHub valueflows/valueflows Value Flows 'vf' vocabs. Contribute to valueflows/valueflows development by creating an account on GitHub. image placeholder
One commitment and one economic event
But there are more places with this "time" attribute
Here, the first economic event is correct, the second isn't , i think: https://github.com/valueflows/valueflows/blob/master/examples/claim.yaml GitHub valueflows/valueflows Value Flows 'vf' vocabs. Contribute to valueflows/valueflows development by creating an account on GitHub. image placeholder
https://github.com/valueflows/valueflows/blob/master/examples/move-crypto.yaml GitHub valueflows/valueflows Value Flows 'vf' vocabs. Contribute to valueflows/valueflows development by creating an account on GitHub. image placeholder
https://github.com/valueflows/valueflows/blob/master/examples/transfer-crypto.yaml GitHub valueflows/valueflows Value Flows 'vf' vocabs. Contribute to valueflows/valueflows development by creating an account on GitHub.
fosterlynn 9:06 AM time:inXSDDateTimeStamp: 2019-04-18T8:00:00-5:00 that one I think you mean
fosterlynn 9:14 AM That is Pavlik's preferred way, using the time vocabulary directly - I didn't like it because the name is a not very meaningful to non-rdf people for whom XSD means nothing - so I added the hasPointInTime to the graphql spec and the UML for non-rdf people, with Pavlik's permission because it is not the "real" spec. We were still in the process of figuring out how to manage rdf vs non-rdf in the vocabulary - Pavlik said we can't have hasPointInTime as part of the real rdf vocabulary and point it in to the time vocabulary like he did with hasBeginning and hasEnd, can't remember the technical reason now. I think I have reconstructed the conversations more or less correctly, although way to simplistically I'm sure. Would be interested in your opinion.
yeff 10:06 AM I think about that reasoning and come back to that.
yeff 10:23 AM || || |"hasBeginning": {| | | "description": "The beginning of the economic event.",| | | "type": "string",| | | "format": "date-time"| | | },| | | "hasEnd": {| | | "description": "The end of the economic event.",| | | "type": "string",| | | "format": "date-time"| | | },| | | "hasPointInTime": {| | | "description": "The date/time at which the economic event occurred. Can be used instead of beginning and end.",| | | "type": "string",| | | "format": "date-time"| | | },| | | "before": {| | | "description": "The economic event occurred prior to this date/time.",| | | "type": "string",| | | "format": "date-time"| | | },| | | "after": {| | | "description": "The economic event occurred after this date/time.",| | | "type": "string",| | | "format": "date-time"| | |
This is a snippet from the JSON-schema with the 5 time related attributes
this is what the UML shows Screenshot 2019-10-04 at 17.22.42.png
my point is that none of those two include a "time:inXSDDateTimeStamp" attribute
Its not just about the format of the attribute, that's another discussion, its about the fact that in the JSON-schema and the UML this attribute is non-existing
yeff 10:32 AM Coming back to the examples, the "hasPointInTime" is the one that should be used instead of "time:inXSDDateTimeStamp"
fosterlynn 10:49 AM I would like that better too.
fosterlynn 11:19 AM Here are some old conversations, the first one probably most relevant. https://github.com/valueflows/valueflows/pull/485 https://github.com/valueflows/valueflows/pull/470 https://github.com/valueflows/valueflows/pull/453
fosterlynn 11:21 AM And I think the only real concern is to get hasPointInTime into some more official place where it is defined, would have to be in VF. But I would want to do it properly as an rdf property. 11:22 AM
(To use it in examples, it will have to be defined in rdf.)
yeff 12:49 PM Commented on fosterlynn's message: And I think the only real concern is to get hasPointInTime into some more official place where it is defined, would have to be in VF. But I would want to do it properly as an rdf property.
Indeed