First pass updates
I managed to find the time to look through your VF schema updates today. All seems pretty straightforward.
I will go through and change a lot of your Int
-> String
changes to ID
at some point- that field type has some extra benefits and also doesn't care whether the input is a string or int- convenient! It's nice to have a struct for time periods too, but at first glance maybe we need to split that into times & periods? It seems like the same type is being used for both. And I can figure out union types for the track/trace queries too, as well as some inheritance stuff to keep it DRY.
Some things look like they don't yet do much (like ExchangeAgreement
), was the idea to stub them and have me go through and fill in fields as I get up to speed with the latest spec? Also curious why so many things in the knowledge schema have been commented out.
Unrelated, but I think the best way forward is to merge all the query-like relationships into single relationships- it seems reasonable to me to aim for the fewest number of edges between nodes, but to have those edges as flexible as possible. I think the filter parameters in such edges are always ANDed together- if you want OR, you can use field aliasing like this to query the same relationship multiple times with different independent criteria.
Anyway, lots more to come when I get the time to iterate on this properly, I'm sure... but those are the things that come up initially.